Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for collection in Tracker #718

Merged
merged 11 commits into from
Jan 20, 2022
Merged

Support for collection in Tracker #718

merged 11 commits into from
Jan 20, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 6, 2022 •
edited
Loading

What does this PR do?

Fixes #681
Enable the option to pass into MetricCollection the wrapper of MetricTracker.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jan 6, 2022
@Borda Borda added this to the v0.8 milestone Jan 6, 2022
@Borda Borda force-pushed the master branch 3 times, most recently from 3a0f7dc to 317182c Compare January 10, 2022 13:05
@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #718 (3b704ba) into master (75e1f54) will increase coverage by 24%.
The diff coverage is 94%.

@@           Coverage Diff           @@
##           master   #718     +/-   ##
=======================================
+ Coverage      71%    95%    +24%     
=======================================
  Files         171    171             
  Lines        6888   6908     +20     
=======================================
+ Hits         4880   6546   +1666     
+ Misses       2008    362   -1646

@SkafteNicki SkafteNicki marked this pull request as ready for review January 20, 2022 14:12
@SkafteNicki SkafteNicki changed the title [WIP] Support for collection in Tracker Support for collection in Tracker Jan 20, 2022
@Borda
Copy link
Member

Borda commented Jan 20, 2022

@SkafteNicki is this ready to go? :]

Borda
Borda approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐰

@Borda Borda enabled auto-merge (squash) January 20, 2022 16:18
@mergify mergify bot added the ready label Jan 20, 2022
@Borda Borda merged commit d6c423e into master Jan 20, 2022
@Borda Borda deleted the tracker_collection branch January 20, 2022 17:22
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees

@SkafteNicki SkafteNicki

Labels
enhancement New feature or request ready
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

MetricCollection with Tracker
3 participants
@SkafteNicki @Borda @justusschock